-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(draft2019-09): upgrading jsonschema to support draft2019-09 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
force-pushed
the
update-draft2019-09
branch
from
April 14, 2020 16:40
f49ac6b
to
b3c1c18
Compare
Added note, will split this up between adding the updated tests and then the implementation as a separate PR. |
b5
reviewed
Apr 15, 2020
@@ -1,5 +1,7 @@ | |||
module github.com/qri-io/jsonschema | |||
|
|||
go 1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use go 1.13 for now. Apparently IPFS doesn't work with 1.14
5 tasks
Arqu
force-pushed
the
update-draft2019-09
branch
from
April 22, 2020 21:37
40db009
to
d205a2a
Compare
Obliterating this PR in favor of the saner ones. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, just added the basline test data so we can start on the actual implementation.